WR: remove used fields in TimeInternal

The three "raw" fields claim to exist for debugging, but since we have several TimeInternal structures around they cost quite some space. The fields were only copied to TimeInternal from network frames, and there is not explicit code to dump them. Thus, this commit removes them but leaves the code in place, so it can be re-enabled if the need arises. (I use the ugly "#if 0"). Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

WR: remove used fields in TimeInternal
The three "raw" fields claim to exist for debugging, but since we have several TimeInternal structures around they cost quite some space. The fields were only copied to TimeInternal from network frames, and there is not explicit code to dump them. Thus, this commit removes them but leaves the code in place, so it can be re-enabled if the need arises. (I use the ugly "#if 0"). Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
e441b48b · Alessandro Rubini · 30677541 · e441b48b · e441b48b
Commit e441b48b authored Feb 28, 2013 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 1 deletion

wrpc-socket.c arch-wrpc/wrpc-socket.c +2 -0

ieee1588_types.h include/ppsi/ieee1588_types.h +7 -1

No files found.
--- a/arch-wrpc/wrpc-socket.c
+++ b/arch-wrpc/wrpc-socket.c
@@ -56,9 +56,11 @@ static int wrpc_net_recv(struct pp_instance *ppi, void *pkt, int len,
 		t->nanoseconds = wr_ts.nsec;
 		t->phase = wr_ts.phase;
 		t->correct = wr_ts.correct;
+#if 0 /* I disabled the fields, for space: they were only used here */
 		t->raw_nsec = wr_ts.raw_nsec;
 		t->raw_ahead = wr_ts.raw_ahead;
 		t->raw_phase = wr_ts.raw_phase;
+#endif
 	}
 	return got;
 }

--- a/include/ppsi/ieee1588_types.h
+++ b/include/ppsi/ieee1588_types.h
@@ -66,10 +66,16 @@ typedef struct TimeInternal {
 	/* White Rabbit extension begin */
 	Integer32	phase;
 	int 		correct;
-	/* raw time (non-linearized) for debugging purposes */
+#if 0
+	/*
+	 * The following three fields may be used for diagnostics, but
+	 * they cost space. So remove them but keep the code around just
+	 * in case it is useful again (they are only set, never read)
+	 */
 	int32_t raw_phase;
 	int32_t raw_nsec;
 	int32_t raw_ahead;
+#endif
 	/* White Rabbit extension end */
 } TimeInternal;