fsm: better error for state failure

This adds the interface name where the error happened (we'll need it for multi-link setups, that Aurelio is going to implement soon). Moreover, this kills the last pp_diag_error call Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

fsm: better error for state failure
This adds the interface name where the error happened (we'll need it for multi-link setups, that Aurelio is going to implement soon). Moreover, this kills the last pp_diag_error call Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
8c1136fe · Alessandro Rubini · c1ec94a7 · 8c1136fe
Commit 8c1136fe authored Mar 07, 2013 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

fsm.c fsm.c +2 -1

No files found.
--- a/fsm.c
+++ b/fsm.c
@@ -102,7 +102,8 @@ int pp_state_machine(struct pp_instance *ppi, uint8_t *packet, int plen)
 			pp_diag_fsm(ppi, ip->name, STATE_ENTER, plen);
 		err = ip->f1(ppi, packet, plen);
 		if (err)
-			pp_diag_error(ppi, err);
+			pp_printf("fsm for %s: Error %i in %s\n",
+				  OPTS(ppi)->iface_name, err, ip->name);

 		/* done: if new state mark it, and enter it now (0 ms) */
 		if (ppi->state != ppi->next_state) {