removed duplicated max_foreign_records option

The correct one is in rt_opts struct. Removed the oldest one, which was still used (but not set to its default) and lead to a division by zero

removed duplicated max_foreign_records option
The correct one is in rt_opts struct. Removed the oldest one, which was still used (but not set to its default) and lead to a division by zero
0db9b19f · Aurelio Colosimo · bce9486f · 0db9b19f · 0db9b19f
Commit 0db9b19f authored Mar 13, 2012 by Aurelio Colosimo
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

pptp.h include/pptp/pptp.h +0 -1

common-fun.c proto-standard/common-fun.c +2 -2

No files found.
--- a/include/pptp/pptp.h
+++ b/include/pptp/pptp.h
@@ -179,7 +179,6 @@ struct pp_instance {
 	struct pp_timer *timers[PP_TIMER_ARRAY_SIZE];

 	UInteger16 number_foreign_records;
-	Integer16  max_foreign_records;
 	Integer16  foreign_record_i;
 	Integer16  foreign_record_best;
 	Boolean  record_update;

--- a/proto-standard/common-fun.c
+++ b/proto-standard/common-fun.c
@@ -104,7 +104,7 @@ void st_com_add_foreign(struct pp_instance *ppi, unsigned char *buf)

 	/* New foreign master */
 	if (ppi->number_foreign_records <
-	    ppi->max_foreign_records) {
+	    OPTS(ppi)->max_foreign_records) {
 		ppi->number_foreign_records++;
 	}

@@ -129,7 +129,7 @@ void st_com_add_foreign(struct pp_instance *ppi, unsigned char *buf)
 	PP_VPRINTF("New foreign Master added \n");

 	ppi->foreign_record_i = (ppi->foreign_record_i+1) %
-		ppi->max_foreign_records;
+		OPTS(ppi)->max_foreign_records;
 }