Make use of #watched_by? in issue form.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3114 e93f8b46-1217-0410-a6f0-8f06a7374b81

Make use of #watched_by? in issue form.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3114 e93f8b46-1217-0410-a6f0-8f06a7374b81
e5dc94fe · Jean-Philippe Lang · 7592a955 · e5dc94fe · e5dc94fe
Commit e5dc94fe authored Dec 02, 2009 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

_form.rhtml app/views/issues/_form.rhtml +1 -1

acts_as_watchable.rb vendor/plugins/acts_as_watchable/lib/acts_as_watchable.rb +2 -3

No files found.
--- a/app/views/issues/_form.rhtml
+++ b/app/views/issues/_form.rhtml
@@ -23,7 +23,7 @@
 <% if @issue.new_record? && User.current.allowed_to?(:add_issue_watchers, @project) -%>
 <p><label><%= l(:label_issue_watchers) %></label>
 <% @issue.project.users.sort.each do |user| -%>
-<label class="floating"><%= check_box_tag 'issue[watcher_user_ids][]', user.id, @issue.watcher_user_ids.include?(user.id) %> <%=h user %></label>
+<label class="floating"><%= check_box_tag 'issue[watcher_user_ids][]', user.id, @issue.watched_by?(user) %> <%=h user %></label>
 <% end -%>
 </p>
 <% end %>

--- a/vendor/plugins/acts_as_watchable/lib/acts_as_watchable.rb
+++ b/vendor/plugins/acts_as_watchable/lib/acts_as_watchable.rb
@@ -46,10 +46,9 @@ module Redmine
          watching ? add_watcher(user) : remove_watcher(user)
        end
        
-        # Returns if object is watched by user
+        # Returns true if object is watched by user
        def watched_by?(user)
-          !self.watchers.find(:first,
-                              :conditions => ["#{Watcher.table_name}.user_id = ?", user.id]).nil?
+          !!(user && self.watchers.detect {|w| w.user_id == user.id })
        end
        
        # Returns an array of watchers' email addresses