Refactor: Move method

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3673 e93f8b46-1217-0410-a6f0-8f06a7374b81

Refactor: Move method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3673 e93f8b46-1217-0410-a6f0-8f06a7374b81
d22723ed · Eric Davis · 88db9d0b · d22723ed · d22723ed
Commit d22723ed authored Apr 16, 2010 by Eric Davis
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 9 deletions

custom_fields_helper.rb app/helpers/custom_fields_helper.rb +1 -9

custom_field_format.rb lib/redmine/custom_field_format.rb +12 -0

No files found.
--- a/app/helpers/custom_fields_helper.rb
+++ b/app/helpers/custom_fields_helper.rb
@@ -95,15 +95,7 @@ module CustomFieldsHelper
  
  # Return a string used to display a custom value
  def format_value(value, field_format)
-    return "" unless value && !value.empty?
-    case field_format
-    when "date"
-      begin; format_date(value.to_date); rescue; value end
-    when "bool"
-      l(value == "1" ? :general_text_Yes : :general_text_No)
-    else
-      value
-    end
+    Redmine::CustomFieldFormat.format_value(value, field_format) # Proxy
  end

  # Return an array of custom field formats which can be used in select_tag

--- a/lib/redmine/custom_field_format.rb
+++ b/lib/redmine/custom_field_format.rb
@@ -61,6 +61,18 @@ module Redmine
          [ l(custom_field_format.label), custom_field_format.name ]
        }
      end
+
+      def format_value(value, field_format)
+        return "" unless value && !value.empty?
+        case field_format
+        when "date"
+          begin; format_date(value.to_date); rescue; value end
+        when "bool"
+          l(value == "1" ? :general_text_Yes : :general_text_No)
+        else
+          value
+        end
+      end
    end
  end 
 end