Some deprecation fixes (end_form_tag and count API).

git-svn-id: http://redmine.rubyforge.org/svn/trunk@676 e93f8b46-1217-0410-a6f0-8f06a7374b81

Some deprecation fixes (end_form_tag and count API).
git-svn-id: http://redmine.rubyforge.org/svn/trunk@676 e93f8b46-1217-0410-a6f0-8f06a7374b81
317b460d · Jean-Philippe Lang · c8b3c8df · 317b460d · 317b460d · 317b460d
Commit 317b460d authored Aug 29, 2007 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 7 deletions

projects_helper.rb app/helpers/projects_helper.rb +4 -4

show.rhtml app/views/account/show.rhtml +1 -1

report.rhtml app/views/roles/report.rhtml +2 -2

No files found.
--- a/app/helpers/projects_helper.rb
+++ b/app/helpers/projects_helper.rb
@@ -178,9 +178,9 @@ module ProjectsHelper
  
  def new_issue_selector
    trackers = Tracker.find(:all, :order => 'position')
-    form_tag({:controller => 'projects', :action => 'add_issue', :id => @project}, :method => :get) +
-      select_tag('tracker_id', '<option></option' + options_from_collection_for_select(trackers, 'id', 'name'),
-        :onchange => "if (this.value != '') {this.form.submit()}") +
-      end_form_tag
+    # can't use form tag inside helper
+    content_tag('form',
+      select_tag('tracker_id', '<option></option' + options_from_collection_for_select(trackers, 'id', 'name'), :onchange => "if (this.value != '') {this.form.submit()}"),
+      :action => url_for(:controller => 'projects', :action => 'add_issue', :id => @project), :method => 'get')
  end
 end
--- a/app/views/account/show.rhtml
+++ b/app/views/account/show.rhtml
@@ -24,5 +24,5 @@

 <h3><%=l(:label_activity)%></h3>
 <p>
-<%=l(:label_reported_issues)%>: <%= Issue.count(["author_id=?", @user.id]) %>
+<%=l(:label_reported_issues)%>: <%= Issue.count(:conditions => ["author_id=?", @user.id]) %>
 </p>
\ No newline at end of file
--- a/app/views/roles/report.rhtml
+++ b/app/views/roles/report.rhtml
 <h2><%=l(:label_permissions_report)%></h2>

-<%= start_form_tag({:action => 'report'}, :id => 'permissions_form') %>
+<% form_tag({:action => 'report'}, :id => 'permissions_form') do %>
 <%= hidden_field_tag 'permissions[0]', '' %>
 <table class="list">
 <thead>
@@ -28,4 +28,4 @@
 </table>
 <p><%= check_all_links 'permissions_form' %></p>
 <p><%= submit_tag l(:button_save) %></p>
-<%= end_form_tag %>
+<% end %>