Correct email sending on attachment to document #1008

1d3cdf1f · Felix Schäfer · 3e84c481 · 1d3cdf1f · 1d3cdf1f
Commit 1d3cdf1f authored May 18, 2012 by Felix Schäfer
Hide whitespace changes
Inline Side-by-side

Showing with 23 additions and 1 deletion

documents_controller.rb app/controllers/documents_controller.rb +1 -1

documents_controller_test.rb test/functional/documents_controller_test.rb +22 -0

No files found.
--- a/app/controllers/documents_controller.rb
+++ b/app/controllers/documents_controller.rb
@@ -85,7 +85,7 @@ class DocumentsController < ApplicationController

    if attachments.present? && attachments[:files].present? && Setting.notified_events.include?('document_added')
      # TODO: refactor
-      attachments.first.container.recipients.each do |recipient|
+      @document.recipients.each do |recipient|
        Mailer.deliver_attachments_added(attachments[:files], recipient)
      end
    end

--- a/test/functional/documents_controller_test.rb
+++ b/test/functional/documents_controller_test.rb
@@ -147,6 +147,28 @@ LOREM
    end
  end

+  context "#add_attachment" do
+    setup do
+      @request.session[:user_id] = 2
+      set_tmp_attachments_directory
+      @document = Document.generate!(:project => Project.find('ecookbook'),
+                                     :title => 'Test')
+    end
+
+    should "send a notification mail" do
+      ActionMailer::Base.deliveries.clear
+      Setting.notified_events = Setting.notified_events.dup << 'document_added'
+
+      post :add_attachment,
+           :id => @document.id,
+           :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
+
+      @document.reload
+      assert_not_nil @document
+      assert_equal 2, ActionMailer::Base.deliveries.size
+    end
+  end
+
  def test_destroy
    @request.session[:user_id] = 2
    post :destroy, :id => 1