Fixed: submitting a non numerical parent task input creates a 500 error (#6932).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4414 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fixed: submitting a non numerical parent task input creates a 500 error (#6932).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4414 e93f8b46-1217-0410-a6f0-8f06a7374b81
06b0176a · Jean-Philippe Lang · 427ec05c · 06b0176a · 06b0176a
Commit 06b0176a authored Nov 20, 2010 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 15 additions and 1 deletion

issue.rb app/models/issue.rb +1 -1

issues_controller_test.rb test/functional/issues_controller_test.rb +14 -0

No files found.
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -276,7 +276,7 @@ class Issue < ActiveRecord::Base
      if !user.allowed_to?(:manage_subtasks, project)
        attrs.delete('parent_issue_id')
      elsif !attrs['parent_issue_id'].blank?
-        attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'])
+        attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
      end
    end
    

--- a/test/functional/issues_controller_test.rb
+++ b/test/functional/issues_controller_test.rb
@@ -525,6 +525,20 @@ class IssuesControllerTest < ActionController::TestCase
    assert_not_nil issue
    assert_equal Issue.find(2), issue.parent
  end
+
+  def test_post_create_subissue_with_non_numeric_parent_id
+    @request.session[:user_id] = 2
+    
+    assert_difference 'Issue.count' do
+      post :create, :project_id => 1, 
+                 :issue => {:tracker_id => 1,
+                            :subject => 'This is a child issue',
+                            :parent_issue_id => 'ABC'}
+    end
+    issue = Issue.find_by_subject('This is a child issue')
+    assert_not_nil issue
+    assert_nil issue.parent
+  end
  
  def test_post_create_should_send_a_notification
    ActionMailer::Base.deliveries.clear