From 477a5f370287fc5b25969883a351cf4f684ef54f Mon Sep 17 00:00:00 2001
From: Eric Davis <edavis@littlestreamsoftware.com>
Date: Mon, 16 May 2011 10:41:53 -0700
Subject: [PATCH] Refactor: replace comment with extracted utility method
---
app/controllers/projects_controller.rb | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb
index 692026a05..44f683400 100644
--- a/app/controllers/projects_controller.rb
+++ b/app/controllers/projects_controller.rb
@@ -70,12 +70,7 @@ class ProjectsController < ApplicationController
if validate_parent_id && @project.save
@project.set_allowed_parent!(params[:project]['parent_id']) if params[:project].has_key?('parent_id')
- # Add current user as a project member if he is not admin
- unless User.current.admin?
- r = Role.givable.find_by_id(Setting.new_project_user_role_id.to_i) || Role.givable.first
- m = Member.new(:user => User.current, :roles => [r])
- @project.members << m
- end
+ add_current_user_to_project_if_not_admin(@project)
respond_to do |format|
format.html {
flash[:notice] = l(:notice_successful_create)
@@ -265,4 +260,13 @@ private
def hide_project_in_layout
@project = nil
end
+
+ def add_current_user_to_project_if_not_admin(project)
+ unless User.current.admin?
+ r = Role.givable.find_by_id(Setting.new_project_user_role_id.to_i) || Role.givable.first
+ m = Member.new(:user => User.current, :roles => [r])
+ project.members << m
+ end
+ end
+
end
--
GitLab