sw:lib: validate trtl_msg_poll() input

The main reason it prevent a successful calloc that does not allocate anything which results in: 'errno = 0' and 'return -1' (which is confusing). Providing invalid inputs is not acceptable Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

sw:lib: validate trtl_msg_poll() input
The main reason it prevent a successful calloc that does not allocate anything which results in: 'errno = 0' and 'return -1' (which is confusing). Providing invalid inputs is not acceptable Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
8a8ece4a · Federico Vaga · 3f88bae2 · 8a8ece4a
Commit 8a8ece4a authored Oct 09, 2019 by Federico Vaga
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

libmockturtle.c software/lib/libmockturtle.c +4 -0

No files found.
--- a/software/lib/libmockturtle.c
+++ b/software/lib/libmockturtle.c
@@ -1073,6 +1073,10 @@ int trtl_msg_poll(struct polltrtl *trtlp,
 	struct pollfd *p;
 	int i, ret;

+	if (!trtlp || !npolls) {
+		errno = EINVAL;
+		return -1;
+	}
 	p = calloc(npolls, sizeof(struct pollfd));
 	if (!p)
 		return -1;