Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Sign in
H
HEV - High Energy Ventilator
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 5
    • Issues 5
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • image/svg+xml
    Discourse
    • Discourse
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Projects
  • HEV - High Energy Ventilator
  • Merge Requests
  • !12

Open
Opened May 11, 2021 by Dónal Murray@dmurray
  • Report abuse
Report abuse

Strip out mmap tooling and simplify polling function

I was reading through the tests and realised that this mmap stuff was making things awkward, it actually serves no purpose in the hevclient. It's a legacy workaround for the webui developers when using flask in developer mode, but really that doesn't belong in the hevclient base class.

I've stripped out the mmap stuff and gone back to the base hevclient. I have also made some readability changes in the hevclient polling function while keeping the functionality unchanged.

If this isn't the right branch to make a merge request just let me know and I can rebase on any of the other branches

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b hevclient-refactor origin/hevclient-refactor

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/ui_test
git merge --no-ff hevclient-refactor

Step 4. Push the result of the merge to GitLab

git push origin ui_test

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 2
  • Pipelines 1
  • Changes 1
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: project/hev!12