Add circlar reference detection to eliminate potential for infinite recursive loop.

775fa2c0 · Will Kamp · 0b3a0a14 · 775fa2c0
Commit 775fa2c0 authored Apr 26, 2016 by Will Kamp
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

dep_file.py hdlmake/dep_file.py +5 -0

No files found.
--- a/hdlmake/dep_file.py
+++ b/hdlmake/dep_file.py
@@ -197,7 +197,12 @@ class DepFile(File):
        if self.dep_level == None:
            if len(self.depends_on) == 0:
                self.dep_level = 0
+            elif self.dep_level >= 1000000:
+                raise Exception("Probably run into a circular reference of file dependencies.")
            else:
+                # set stupidly large value so can detect if the recusion below brings us back to
+                # this file in a circular reference, that would otherwise result in an infinite loop.
+                self.dep_level = 1000000
                # recurse, to find the largest number of levels below.
                self.dep_level = 1 + max([dep.get_dep_level() for dep in self.depends_on]);
        return self.dep_level