software: kernel: hwmon: Remove unnecessary variable

Instead of having a static string, in char-array, which will be then put into another string; we can directly put the value in devm_kasprintf() Reported-by: Federico Vaga <federico.vaga@cern.ch> Signed-off-by: Vaibhav Gupta <vaibhav.gupta@cern.ch>

software: kernel: hwmon: Remove unnecessary variable
Instead of having a static string, in char-array, which will be then put into another string; we can directly put the value in devm_kasprintf() Reported-by: Federico Vaga <federico.vaga@cern.ch> Signed-off-by: Vaibhav Gupta <vaibhav.gupta@cern.ch>
21ac3dda · Vaibhav Gupta · 6ba837ca · 21ac3dda
Commit 21ac3dda authored Feb 09, 2023 by Vaibhav Gupta
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

ft-hwmon.c software/kernel/ft-hwmon.c +1 -3

No files found.
--- a/software/kernel/ft-hwmon.c
+++ b/software/kernel/ft-hwmon.c
@@ -66,7 +66,6 @@ static const struct hwmon_chip_info ft_hwmon_temp_chip_info = {

 int ft_hwmon_init(struct fmctdc_dev *ft)
 {
-	char device_type[] = "Temperature - ";
 	struct device *dev = &ft->pdev->dev;

 	ft->hwmon_dev = devm_hwmon_device_register_with_info(dev,
@@ -77,8 +76,7 @@ int ft_hwmon_init(struct fmctdc_dev *ft)
 	if(!IS_ERR(ft->hwmon_dev)) {
 		ft->hwmon_temp_sensor_id = devm_kasprintf(ft->hwmon_dev,
 							  GFP_KERNEL,
-							  "%s%s",
-							  device_type,
+							  "Temperature [%s]",
 							  dev_name(&ft->slot->dev));
 		if(!ft->hwmon_temp_sensor_id) {
 			devm_hwmon_device_unregister(dev);