Skip to content

F
FMC TDC 1ns 5cha - Software
Commit 0630edbb authored by Federico Vaga's avatar Federico Vaga
Browse files
Options

kernel: add WR manual offset for old calibration data 

Apparently the White-Rabbit calibration offset is wrong for the FMC-TDC
mezzanines calibrated before 2018-01-01 (in the future, we are still fixing
the issue). this patch allows to overwrite that value.

It adds also the carrier components. The total WR offset depends on the carrier
as well. The calibration is "always" done with a SPEC, so in principle you
should add/subtract a carrier offset only if you are using a board
different than SPEC

Note
The problem is not easy to spot and there are many FMC-TDC mezzanine produced
and already calibrated. The good thing to do is to replace the value on the
eeprom for all of them, but we cannot. So, we need this hack
Signed-off-by: Federico Vaga's avatarFederico Vaga <federico.vaga@cern.ch>
parent c70b18ca
Hide whitespace changes
Inline Side-by-side
Showing with 63 additions and 1 deletion
kernel/calibration.c
View file @ 0630edbb
......@@ -15,16 +15,31 @@
#include <linux/time.h>
#include <linux/firmware.h>
#include <linux/jhash.h>
#include <linux/slab.h>
#include <linux/ipmi-fru.h>
#include "libsdbfs.h"
#include "fmc-tdc.h"
static u32 wr_calibration_offset = 229460;
module_param_named(wr_offset_fix, wr_calibration_offset, int, 0444);
MODULE_PARM_DESC(wr_offset_fix,
"Overwrite the White-Rabbit calibration offset for calibration value computer before 2018. (Default: 229460 [ps])");
static u32 wr_calibration_offset_carrier = 0;
module_param_named(wr_offset_carrier, wr_calibration_offset_carrier, int, 0444);
MODULE_PARM_DESC(wr_offset_carrier,
"White-Rabbit carrier calibration offset. (Default SPEC: 0 [ps])");
/* dummy calibration data - used in case of empty/corrupted EEPROM */
static struct ft_calibration default_calibration = {
{0, 86, 609, 572, 335}, /* zero_offset */
43343 /* vcxo_default_tune */
};
#define WR_OFFSET_FIX_YEAR (2018)
/* sdbfs-related function */
static int ft_read_calibration_eeprom(struct fmc_device *fmc, void *buf,
int length)
......@@ -55,13 +70,50 @@ static int ft_read_calibration_eeprom(struct fmc_device *fmc, void *buf,
return ret;
}
/**
* HACK area to get the calibration year
*/
static u32 __get_ipmi_fru_id_year(struct fmctdc_dev *ft)
{
struct fru_board_info_area *bia;
struct fru_type_length *tmp;
unsigned long year = 0;
char *buf = NULL;
int err, i;
bia = fru_get_board_area((const struct fru_common_header *)ft->fmc->eeprom);
tmp = bia->tl;
for (i = 0; i < 4; ++i) {
tmp = fru_next_tl(tmp);
if (!tmp)
goto out;
}
if (!fru_length(tmp))
goto out;
if (fru_type(tmp) != FRU_TYPE_ASCII)
goto out;
buf = kmalloc(fru_length(tmp), GFP_ATOMIC);
if (!buf)
goto out;
buf = fru_strcpy(buf, tmp);
buf[4] = '\0';
err = kstrtoul(buf, 10, &year);
if (err)
goto out;
out:
kfree(buf);
return year;
}
/* This is the only thing called by outside */
int ft_handle_eeprom_calibration(struct fmctdc_dev *ft)
{
struct ft_calibration *calib;
struct device *d = &ft->fmc->dev;
int i;
u32 raw_calib[7];
u32 raw_calib[7], year;
/* Retrieve and validate the calibration */
calib = &ft->calib;
......@@ -88,6 +140,16 @@ int ft_handle_eeprom_calibration(struct fmctdc_dev *ft)
calib->calibration_temp = le32_to_cpu(raw_calib[5]);
calib->wr_offset = le32_to_cpu(raw_calib[6]) / 100;
year = __get_ipmi_fru_id_year(ft);
if (year < WR_OFFSET_FIX_YEAR) {
calib->wr_offset = wr_calibration_offset;
dev_warn(d,
"Apply default calibration correction to White-Rabbit offset if done before 2018 (%d)\n",
year);
}
calib->wr_offset += wr_calibration_offset_carrier;
if (ft->verbose) {
/* Print verbose messages */
for (i = 0; i < ARRAY_SIZE(calib->zero_offset); i++)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment