kernel: mask user value before write register

This patch mask the user value before write it on the hardware register. If the value does not fit the mask it will be printed a warning message. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

kernel: mask user value before write register
This patch mask the user value before write it on the hardware register. If the value does not fit the mask it will be printed a warning message. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
b041c02f · Federico Vaga · 3ec22d7e · b041c02f
Commit b041c02f authored Apr 16, 2014 by Federico Vaga
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

fmc-adc.h kernel/fmc-adc.h +5 -0

No files found.
--- a/kernel/fmc-adc.h
+++ b/kernel/fmc-adc.h
@@ -471,6 +471,11 @@ static inline void fa_writel(struct fa_dev *fa,
 		/* */
 		cur &= ~field->mask; /* clear bits according to the mask */
 		val = usr_val * (field->mask & -(field->mask));
+		if (val & ~field->mask)
+			dev_warn(fa->fmc->hwdev,
+				"addr 0x%x: value 0x%x doesn't fit mask 0x%x\n",
+				base_off+field->offset, val, field->mask);
+		val &= field->mask;
 		val |= cur;
 	}
 	fmc_writel(fa->fmc, val, base_off+field->offset);