hdl: Made manual pulse trigger work properly
Prior to this commit, manual pulse triggering did not work when the glitch
filter was enabled. Now, this was fixed by extending the trigger pulse the
conv_man_trig module generates. This accounts for the situation where the
pulse generator has the glitch filter enabled.
I also fixed a bug in conv_pulse_gen; this fix was commited two commits ago.
The bug consisted of the gf_off part of the pulse generator triggering even
when the glitch filter was enabled. This resulted in a continuous high pulse
generated on the output when the glitch filter was switched from on to off.
Granted, such a situation should not occur in operation, since a board needs
to be removed from the crate in order to flip a switch. Nonetheless, it was a
but, so I've fixed it by making sure the gf_off part of the design only triggers
when the glitch filter is disabled:
if (en_i = '1') and (gf_en_n_i = '1') then
pulse_gf_off <= '1';
end if;
A warning will be placed in the docs for release versions 1.0 and 0.0 (golden).
Signed-off-by: Theodor Stana <t.stana@cern.ch>
Showing
Please
register
or
sign in
to comment